[Widp] Implement login with two factor #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
xurxodev
changed the title
xurxodev
changed the title
Base automatically changed from
feature-widp/bring_last_changes_3_0_1
to
develop-widp
January 7, 2025 10:42
ifoche
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Sorry @xurxodev but after multiple tests I think I can confirm that this is not working for me. It repeately throws me a "Session expired" error, no matter how fast I copy the 2FA code. Let's try to find a time next week to do it together please.
ifoche
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
⚙️ branches
app:
Origin: feature-widp/implement_two_factor Target: develop-widp
dhis2-android-SDK:
Origin: develop-eyeseetea
🎩 What is the goal?
Implement two factor login
📝 How is it being implemented?
💥 How can it be tested?
2.41 - user with two-factor code enabled should can to log in
2.41 - user without two-factor code enabled should can to log in
2.40 - user with two-factor code enabled - Not work because new endpoint doesn't exist
2.40 - user without two-factor code enabled should can to log in
2.39 - user with two-factor code enabled - Not work because new endpoint doesn't exist
2.39 - user without two-factor code enabled should can to log in
💾 Requires DB migration?
🎨 UI changes?